Skip to content

Conversation

@chris-langfield
Copy link
Collaborator

As discussed in #502, we can add the option to pre-downsample the data prior to saving. aspire extract-particles creates a CoordinateSource from micrograph/coordinate file data and then saves to a STAR file / .mrcs stack.

It is probably a good idea to also add other preprocessing options, since it might be best to do certain operations prior to downsampling (e.g. noise estimation).

Overall, the downsampling step is critical because without it, running extract-particles will make a copy of the dataset in a different format, but at the same resolution, which would take up unnecessary disk space.

@chris-langfield chris-langfield self-assigned this Jan 28, 2022
@chris-langfield chris-langfield added the enhancement New feature or request label Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #551 (0edc006) into develop (717e19d) will increase coverage by 0.02%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #551      +/-   ##
===========================================
+ Coverage    87.17%   87.19%   +0.02%     
===========================================
  Files          108      108              
  Lines         7984     7998      +14     
===========================================
+ Hits          6960     6974      +14     
  Misses        1024     1024              
Impacted Files Coverage Δ
src/aspire/commands/preprocess.py 0.00% <0.00%> (ø)
src/aspire/commands/extract_particles.py 85.71% <100.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717e19d...0edc006. Read the comment docs.

@chris-langfield chris-langfield marked this pull request as ready for review February 10, 2022 15:19
@chris-langfield
Copy link
Collaborator Author

Improved the help messages and also standardized the help messages, flags, and lack of periods across preprocess and extract-particles. In particular, default --downsample behavior is to not downsample, rather than to downsample to 16.

@janden
Copy link
Collaborator

janden commented Feb 16, 2022

Improved the help messages and also standardized the help messages, flags, and lack of periods across preprocess and extract-particles.

Great!

In particular, default --downsample behavior is to not downsample, rather than to downsample to 16.

Thanks for catching.

@chris-langfield chris-langfield merged commit f60f221 into develop Feb 16, 2022
@chris-langfield chris-langfield deleted the extract_particles_downsample branch February 16, 2022 15:22
garrettwrong pushed a commit that referenced this pull request Feb 22, 2022
* added --downsample option to aspire extract-particles

* added --downsample option to aspire extract-particles

* added normalize_bg and invert_contrast flags

* add --whiten option

* new black version formatting

* help messages and standardize preprocess and extract-particles

* downsample images not data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

preprocess command line option: expand and integrate with EmanSource

3 participants