-
Notifications
You must be signed in to change notification settings - Fork 26
Redundant method eval_filter_grid in ImageSource
#517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97e8093 to
d8a9840
Compare
Codecov Report
@@ Coverage Diff @@
## develop #517 +/- ##
========================================
Coverage 86.54% 86.54%
========================================
Files 106 106
Lines 7660 7660
========================================
Hits 6629 6629
Misses 1031 1031
Continue to review full report at Codecov.
|
|
As discussed earlier it seems like the best solution here is to simply move the whole method into |
garrettwrong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, one todo, otherwise lgtm. Hit those and should be ready to undraft. Thanks
remove method from ImageSource fix imports no self import cleanup docstring clarity and style fixes
aa9f83e to
ca34247
Compare
|
Rebased / squash prior to undraft |
Address #38
I'm not sure if this method is unnecessary. The code in
eval_filter_griddoes some manipulation with thefilter_indicesof the source that is only applicable within that class.It is only used in two implementations of the
Estimator.compute_kernelmethod: inaspire.reconstruction.meanandaspire.covariance.covar