Skip to content

fix oversight in circ and inverse_r centering #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2021
Merged

fix oversight in circ and inverse_r centering #456

merged 3 commits into from
Sep 17, 2021

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Sep 14, 2021

Forgot to plumb arguments for x0 y0. Found when using circ for something yesterday.

@garrettwrong garrettwrong added the bug Something isn't working label Sep 14, 2021
@garrettwrong garrettwrong requested a review from j-c-c September 14, 2021 14:13
@garrettwrong garrettwrong self-assigned this Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #456 (482eab5) into develop (b893bef) will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #456      +/-   ##
===========================================
+ Coverage    87.87%   88.15%   +0.27%     
===========================================
  Files          105      105              
  Lines         7530     7716     +186     
===========================================
+ Hits          6617     6802     +185     
- Misses         913      914       +1
Impacted Files Coverage Δ
src/aspire/utils/misc.py 88.46% <0.00%> (ø)
src/aspire/source/image.py 95.75% <0.00%> (+0.26%) ⬆️
src/aspire/basis/fspca.py 97.36% <0.00%> (+0.79%) ⬆️
src/aspire/operators/blk_diag_matrix.py 96.01% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b893bef...482eab5. Read the comment docs.

j-c-c
j-c-c reviewed Sep 16, 2021
View reviewed changes
@garrettwrong garrettwrong requested a review from j-c-c September 16, 2021 16:15
j-c-c
j-c-c approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Sep 17, 2021

Merging this minor fix so we can move on with the release.

@garrettwrong garrettwrong merged commit f2813a2 into develop Sep 17, 2021
@garrettwrong garrettwrong deleted the fix_util_func_bug branch September 17, 2021 14:32
@janden
Copy link
Collaborator

janden commented Sep 17, 2021

Sorry meant to approve this yesterday. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrettwrong @janden @j-c-c