Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

#444 brought in the irregular (non square) block diagonal matrix feature. This PR uses the new feature in the FSPCA compression area of the class averaging implementation.

Also adds related syntactic sugar and tests used for that invocation.

Closes #442

@garrettwrong garrettwrong added enhancement New feature or request cleanup labels Sep 3, 2021
@garrettwrong garrettwrong self-assigned this Sep 3, 2021
@garrettwrong
Copy link
Collaborator Author

@chris-langfield , do you want to practice the review process with me? Lets look for any typos, missing/incorrect code, or unclear areas in the change set before we undraft it and it gets sent to Joakim.

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #452 (7b8185d) into develop (b893bef) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #452      +/-   ##
===========================================
+ Coverage    87.87%   87.90%   +0.03%     
===========================================
  Files          105      105              
  Lines         7530     7535       +5     
===========================================
+ Hits          6617     6624       +7     
+ Misses         913      911       -2     
Impacted Files Coverage Δ
src/aspire/basis/fspca.py 96.51% <100.00%> (-0.06%) ⬇️
src/aspire/operators/blk_diag_matrix.py 95.72% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b893bef...7b8185d. Read the comment docs.

chris-langfield
chris-langfield previously approved these changes Sep 3, 2021
@garrettwrong garrettwrong marked this pull request as ready for review September 3, 2021 17:27
@garrettwrong garrettwrong requested a review from janden as a code owner September 3, 2021 17:27
@garrettwrong garrettwrong merged commit 9866e0a into develop Sep 9, 2021
@garrettwrong garrettwrong deleted the cls_blk_patch_442 branch September 22, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants