-
Notifications
You must be signed in to change notification settings - Fork 26
ArrayImageSource admit numpy #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #449 +/- ##
===========================================
+ Coverage 87.88% 88.51% +0.63%
===========================================
Files 97 105 +8
Lines 6675 7944 +1269
===========================================
+ Hits 5866 7032 +1166
- Misses 809 912 +103
Continue to review full report at Codecov.
|
|
Cool so I think in I have not tested this, but I think something like this should work fine for us. @j-c-c , could you try to add this into the branch, test it, commit, and push it up? |
garrettwrong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks. We still need to:
-
Add a test that tries to create a class with non compliant input (say a numpy array with shape (3,2,1) ), and check it returns a meaningful error message.
-
Use this feature to simplify some of the tutorial/example code.
3f4085d to
6cf86ac
Compare
garrettwrong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I think this covers the issue. Thanks.
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds code and tests for using numpy arrays directly with ArrayImageSource.