-
Notifications
You must be signed in to change notification settings - Fork 26
Add wbemd 418 #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wbemd 418 #419
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #419 +/- ##
===========================================
+ Coverage 86.93% 87.91% +0.97%
===========================================
Files 91 96 +5
Lines 6171 6851 +680
===========================================
+ Hits 5365 6023 +658
- Misses 806 828 +22
Continue to review full report at Codecov.
|
|
Closes #418 |
|
@mosco , any word on the unit test progress? Thanks |
Unit test is done. I also updated the code slightly to support general n-dimensional arrays and non-normalized arrays. |
b26cb2b to
05bcc10
Compare
|
Outstanding, thanks! I was getting worried 😅. I looked it over and fixed up the syntax checking, also some line length tweaks that would have probably come up in review. If the test passes on all the platforms it should be ready for Joakim to review. Thanks! |
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few things.
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing.
Adds contributed code for wavelet based earth mover distance approximation.
Currently I stubbed in a smoke test, but Amit M to work on a more suitable test. I don't think that we need to exercise the theoretical bounds in the test. Maybe we can just see if distance between two controlled (gaussian?) clouds is reasonable.
While I admittedly liked the syntax of the docstring a little more in the original contribution, it was changed to be more consistent with most of the project.