Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Closes #413

It appears the latest Black formatting wants to cleanup some of the docstrings. I put those in a separate commit, but I didn't think it was worth another PR atm.

Will undraft after the CI finishes in case any surprises pop up.

@garrettwrong garrettwrong added bug Something isn't working cleanup labels May 3, 2021
@garrettwrong garrettwrong self-assigned this May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #414 (b9d99ea) into develop (015992e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #414      +/-   ##
===========================================
+ Coverage    86.92%   86.93%   +0.01%     
===========================================
  Files           91       91              
  Lines         6171     6171              
===========================================
+ Hits          5364     5365       +1     
+ Misses         807      806       -1     
Impacted Files Coverage Δ
src/aspire/apple/picking.py 94.08% <ø> (ø)
src/aspire/reconstruction/estimator.py 92.40% <ø> (ø)
src/aspire/volume/__init__.py 91.42% <ø> (ø)
src/aspire/source/image.py 92.19% <100.00%> (ø)
src/aspire/source/simulation.py 99.46% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015992e...b9d99ea. Read the comment docs.

@garrettwrong garrettwrong marked this pull request as ready for review May 3, 2021 19:12
@garrettwrong garrettwrong requested a review from janden as a code owner May 3, 2021 19:12
@garrettwrong garrettwrong merged commit 004ba5e into develop May 6, 2021
@garrettwrong garrettwrong deleted the fix_413 branch June 8, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants