Fixes corner case where filter eval points outside interp grid. #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odd resolution images could cause omegas outside grid (arithmetic noise 1 vs 0.9999999). Allow extrapolation in this case instead of zero fill which will crash in later (PowerFilter) computations. Also implements short circuit optimization for case where transfer function grid is expected to be identical to interpolation grid. No need to interpolate there.
Codecov Report
@@ Coverage Diff @@
## develop #409 +/- ##
===========================================
+ Coverage 86.90% 86.92% +0.01%
===========================================
Files 91 91
Lines 6162 6171 +9
===========================================
+ Hits 5355 5364 +9
Misses 807 807
Continue to review full report at Codecov.
|
janden
requested changes
Apr 1, 2021
janden
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odd resolution images could generate omegas outside grid (0.9999999 to 89.0000001 vs 1 to 89). Allow extrapolation in this case instead of zero fill which will crash in later (PowerFilter) computations. The exact case to produce this situation was a user supplied stack of 89x89 images, directly or under various odd downsample resolutions.
Also implements short circuit optimization for case where transfer function grid is expected to be identical to interpolation grid. No need to interpolate there. The reported case is one of these situations where no interpolation was even necessary.
Resolves #401 nans.