add some more tests for Rotation class #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is happening because the Rotation class crashed for me when it tried to print/log itself (fixed elsewhere)... so besides fixing that I want to check all the class's methods are at least invoked by pytest. I think some of the more advanced calls were already covered with some scrutiny. I didn't run into any other crashes yet.
One concern, is whether there is a more robust way to implement
testCommonLiness.t. we can easily changenum_rotsat will. Flexingnum_rotsby hand I found one other flaky test (up toatol), but I can imagine other reasons that might cause this particulartestCommonLinesresult to change over time...