Skip to content

Reimplement real spherical harmonic function #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Reimplement real spherical harmonic function #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17bcc1e
Reimplement real spherical harmonic function
junchaoxia Nov 30, 2020
4ddf3fb
Add passing of image size in simulation object
junchaoxia Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions src/aspire/basis/basis_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import numpy as np
from numpy import diff, exp, log, pi
from numpy.polynomial.legendre import leggauss
from scipy.special import jn, jv, lpmv
from scipy.special import jn, jv, lpmv, sph_harm

from aspire.utils import ensure
from aspire.utils.coor_trans import grid_2d, grid_3d
Expand Down Expand Up @@ -126,26 +126,14 @@ def real_sph_harmonic(j, m, theta, phi):
:return: The real spherical harmonics evaluated at the points (theta, phi).
"""
abs_m = abs(m)
y = lpmv(abs_m, j, np.cos(theta))

# Beware of using just np.prod in the denominator here
# Unless we use float64, values in the denominator > 13! will be incorrect
try:
y = (
np.sqrt(
(2 * j + 1)
/ (4 * pi)
/ np.prod(range(j - abs_m + 1, j + abs_m + 1), dtype=np.float64)
)
* y
)
except RuntimeWarning:
logger.error("debug")

y = sph_harm(abs_m, j, phi, theta)
if m < 0:
y = np.sqrt(2) * np.sin(abs_m * phi) * y
y = np.sqrt(2) * np.imag(y)
elif m > 0:
y = np.sqrt(2) * np.cos(abs_m * phi) * y
y = np.sqrt(2) * np.real(y)
else:
y = np.real(y)

return y

Expand Down
1 change: 1 addition & 0 deletions tutorials/examples/cov3d_simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

# Create a simulation object with specified filters
sim = Simulation(
L=img_size,
n=num_imgs,
C=num_vols,
unique_filters=[RadialCTFFilter(defocus=d) for d in np.linspace(1.5e4, 2.5e4, 7)],
Expand Down