Failing CI Pipelines #146
Merged
Failing CI Pipelines #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
bug
garrettwrong
force-pushed
the
dbg_ci_windows
branch
from
288aa8b to
13af208
Compare
garrettwrong
force-pushed
the
dbg_ci_windows
branch
from
13af208 to
ebb169c
Compare
junchaoxia
reviewed
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I narrowed the windows failures down to loosening
atolas below for consistence with other single precision tests. In double precision the test (test_simulation) passed comparison with the original reference result. I am not sure at what point this began to fail, perhaps someone else can comment. The tolerance is a little loose for my taste, but probably fair for singles broad cross-platform supportI scheduled a nightly build for master and develop in the
azure-pipelines.yml. This should help us stay current with rolling azure/platform updates, which I think recently broke the pipelines for some time.I could not find any (yaml) documentation on an automated retry for jobs that fail due to Azure platform issues. These happen occasionally, but more than they should. It seems we can only retry from UI. If it becomes detrimental, we can explore options again.
Removed WIP Draft status. after observed nightly test ran. I removed this branch name from the inclusions in the pipeline yaml (testing purposes) and rebased the commits.