-
Notifications
You must be signed in to change notification settings - Fork 26
Fix some bugs estimating shifts #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
[skip ci]
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1338 +/- ##
========================================
Coverage 90.65% 90.65%
========================================
Files 134 134
Lines 14431 14429 -2
========================================
- Hits 13082 13081 -1
+ Misses 1349 1348 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Confirmed the Yeast dataset is also improved. The gallery published recon script for 10073 dataset now yields a better recon FSC score than published in the JSB paper, even with the other remaining known opportunities for improvement in ASPIRE-Python. Got bogged down with some tests and creating an issue #1340 . I just need self review this then I'll open it up. |
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Brings us about 2A closer to MATLAB's recon. This appears to have been most of the remaining discrepancy in the 3D pipeline following orientation estimation. After porting over pages of code and intermediate results from MATLAB to make things match numerically I was able to work backwards down to a very small set of changes.
Two major problems.
Minor problems.
A note about solving for shifts... With a capable modern machine we can actually fit the entire system of equations for a few thousand images and solve it quickly. IMO its probably worth just doing that when we can, but not right now.