Skip to content

Conversation

@Sergio0694
Copy link
Member

Docs for CommunityToolkit/WindowsCommunityToolkit#3229

NOTE: the toc.md file is just a placeholder and is taken from the actual docs repo, just adding the section for the MVVM package. So all the other links are actually invalid with respect to the branch on its own (same for assets missing, etc.).

@Sergio0694 Sergio0694 added the documentation Improvements or additions to documentation label Jul 21, 2020
@michael-hawker
Copy link
Member

Thanks @Sergio0694

Let's do a light pass on this, and we can break-out larger changes or improvements as separate tasks/PRs?

@michael-hawker
Copy link
Member

@Sergio0694 we should also have an abridged version of the Intro in the Readme for the repository root as well as calling out samples etc... think we should do that as a separate PR or start the skeleton of that here?

@mrlacey
Copy link
Collaborator

mrlacey commented Jul 27, 2020

@Sergio0694 we should also have an abridged version of the Intro in the Readme for the repository root as well as calling out samples etc... think we should do that as a separate PR or start the skeleton of that here?

I thought the idea was to make this a quick PR to get the docs in and then make subsequent changes separately. I know I've raised dozens of comments on this already but I did feel a little bit worse every time I did so.

@Sergio0694
Copy link
Member Author

@michael-hawker I think we should do that as a separate PR to get this one merged in, yeah 👍

@mrlacey Don't say that, those feedbacks were super useful! And we've almost addressed all of them already! 😊

@michael-hawker
Copy link
Member

@Sergio0694 we should also have an abridged version of the Intro in the Readme for the repository root as well as calling out samples etc... think we should do that as a separate PR or start the skeleton of that here?

I thought the idea was to make this a quick PR to get the docs in and then make subsequent changes separately. I know I've raised dozens of comments on this already but I did feel a little bit worse every time I did so.

Agree, good points. Let's merge this in now, and we can make incremental improvements as we go! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants