Skip to content

Additional unit tests for option pane generator #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 30, 2022
Merged

Additional unit tests for option pane generator #178

merged 9 commits into from
Jun 30, 2022

Conversation

@Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jun 29, 2022 •
edited
Loading

Closes #175

This PR

@michael-hawker
Copy link
Member

michael-hawker commented Jun 30, 2022

@Arlodotexe test run failed here it looks like (at least in the WinUI 2 job):

Failed PaneOptionWithDuplicateName_AllowedBetweenSamples [[28](https://github.com/CommunityToolkit/Labs-Windows/runs/7122169328?check_suite_focus=true#step:14:29)1 ms]
  Error Message:
   Assert.IsTrue failed. Expected no generated compilation errors. Got: 
[CS1061: 'Sample' does not contain a definition for 'Test' and no accessible extension method 'Test' accepting a first argument of type 'Sample' could be found (are you missing a using directive or an assembly reference?)]
  Stack Trace:
     at CommunityToolkit.Labs.Core.SourceGenerators.Tests.ToolkitSampleMetadataTests.VerifyGeneratedDiagnostics[TGenerator](SyntaxTree syntaxTree, String markdown, String[] diagnosticsIds) in /_/common/CommunityToolkit.Labs.Core.SourceGenerators.Tests/CommunityToolkit.Labs.Core.SourceGenerators.Tests/ToolkitSampleMetadataTests.cs:line 448
   at CommunityToolkit.Labs.Core.SourceGenerators.Tests.ToolkitSampleMetadataTests.VerifyGeneratedDiagnostics[TGenerator](String source, String markdown, String[] diagnosticsIds) in /_/common/CommunityToolkit.Labs.Core.SourceGenerators.Tests/CommunityToolkit.Labs.Core.SourceGenerators.Tests/ToolkitSampleMetadataTests.cs:line 399
   at CommunityToolkit.Labs.Core.SourceGenerators.Tests.ToolkitSampleMetadataTests.PaneOptionWithDuplicateName_AllowedBetweenSamples() in /_/common/CommunityToolkit.Labs.Core.SourceGenerators.Tests/CommunityToolkit.Labs.Core.SourceGenerators.Tests/ToolkitSampleMetadataTests.cs:line 235

@michael-hawker michael-hawker added this to the Initial Release milestone Jun 30, 2022
michael-hawker
michael-hawker reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question for clarification, otherwise seems good?

@michael-hawker michael-hawker merged commit ed6b130 into main Jun 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the tests/sample-option-generator-duplicate-propnames-in-asm branch June 30, 2022 22:06
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
@Arlodotexe
Additional unit tests for option pane generator (CommunityToolkit#178)
cc37d5d 
* Added simple test to ensure property generates without errors

* Revert "Fixed issue where using the same property name in multiple samples within the same assembly broken the generator"

This reverts commit 13e85f4.

* Added test to ensure using the same property name in multiple samples compiles successfully

* Revert "Revert "Fixed issue where using the same property name in multiple samples within the same assembly broken the generator""

This reverts commit 005aec8.

* Undo uneeded edits

* Undo uneeded edits

* Remove uneeded duplicate attribute

* Remove uneeded duplicate attribute

* Added link to original issue for new test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

No one assigned

Labels

source generator ⚙️ testing 🏗

Projects

None yet

Milestone

Initial Release

Development

Successfully merging this pull request may close these issues.

Test ToolkitSampleOptionGenerator when multiple samples in the same assembly use the same property name

2 participants

@Arlodotexe @michael-hawker