-
Notifications
You must be signed in to change notification settings - Fork 79
Add rescap to template manifest for future Input Injection work #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like we're also hitting microsoft/WindowsAppSDK#2631 (at least in the experiment job trying to run the tests against the WinAppSDK head). Put details in the issue and will follow-up. Fixing build issues and trying again to see if I can get results from UWP tests. |
e1b1253 to
eaf92be
Compare
|
Failing do to the linked issue, so we need to wait for 1.1.2 of the WindowsAppSDK here. But this was interesting to see on the UWP test results at least:
Need to see what happens with the WinAppSDK side of things, as there's another known issue with the But if it's passing in the UWP pipeline, will have to try adding some more tests and seeing what happens. Seems promising! 🤞 FYI @chingucoding as you may find this investigation interesting as well! |
4a4d4e2 to
eb9200c
Compare
|
Alright, actually implementing the Input Injection is blocked on us not being able to migrate to 1.1.1 (waiting on 1.1.2) and even then there may be a MSTest regression still (following up with platform team). In the meantime, I've rebased this PR to just be the change to the package manifests to add the restricted capability needed. This will enable us to add InputInjection later without needing to modify new experiments (as everything will be encapsulated in the common folder outside of newly written tests using that new functionality). For now I've put my current (yet not completely functional) work in the |
Arlodotexe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No obvious issues, looks good.
Add missing rescaps as missed adding to template in #161
Want to see if the UWP test passes in the CI (WinAppSDK won't work locally as test point is out of place, so expect that to fail.)
Based off of #156, so don't look at changes here until that's merged to main.