use GlobalUsings files #154
Conversation
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Some general questions based on what here's so far. Were you able to resolve the issue with UWP you had earlier?
|
Think there's merge conflicts from the file scoped namespaces, so you'll want to rebase. |
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Don't forget to strip out the locale from the docs urls. 🙂
…ops file to reuse
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
commiting to test wider on the CI
Yes, different groupings seems to have sorted it so that everything builds. I think the background compilation issue was what I was seeing previously. |
|
The SourceGenerators and platform heads still have some using declarations as removing them all would require even more |
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
This is looking so much cleaner! I'm thinking later this is going to help with a lot of merging/refactoring of the streams later too as we can just chop the usings out of those files.
Have a few suggestions for clean-up, but think we're close! @Arlodotexe want to take a look too?
|
Hopefully that's everything now |
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Awesome! 🎉🎉🎉
Thanks @mrlacey for the back-and-forth on this, really looking lean and clean now!
* WIP * put all test related namespaces in a single file * Add GloblaUsings for System.* namespaces - used everywhere * Start to move other Windows/Microsoft namespaces to a single file * Don't include Rider temp/cache files * Add link to docs explaining global using directives * xPlatform projects need linked GU_Labs file as don't have a shared props file to reuse * Update common/GlobalUsings_Tests.cs Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]> * Update common/GlobalUsings_Labs.cs Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]> * Update common/GlobalUsings.cs Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]> * Update GlobalUsings_Labs.cs * simplify and standardize including GU_Labs * Remove explicit `using Windows.Foundation;` to try and address CI build failures * fix duplication of global usings * Tidy up the CanvasLayout usings commiting to test wider on the CI * remove using declarations from SizerBase * remove using declarations from template * Add all GlobalUsings to the Solution so easily accessible * Add license header to GlobalUsings files * Expand comments explaining the GlobalUsings files * Don't use a shared "Microsoft.UI.Xaml.Controls" declaration * Remove duplication from GU_Tests * Standardize filename pluralization * centralize declarations for Automation namespaces * rename GU_Labs > GU_WinUI * Remove GU_Experiments as unneeded Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
2 participants
Fixes #144