Skip to content

feat: improve multi-package selection handling #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: manager/conflict-notification/restore
Choose a base branch
from
Draft

feat: improve multi-package selection handling #5116

wants to merge 3 commits into from

Conversation

viva-jinyi
Copy link
Collaborator

@viva-jinyi viva-jinyi commented Aug 20, 2025 •
edited
Loading

Summary

  • Enhanced multi-package selection UI to properly handle mixed installation states
  • Improved conflict detection to check each package individually
  • Added dynamic status display based on package priority

Changes

  • Check each package individually for conflicts in the install dialog
  • Only show packages with actual conflicts in the warning dialog
  • Hide action buttons when selection contains both installed and uninstalled packages
  • Display the most important status (banned > deleted > flagged > pending > active) from selected packages
  • Deduplicate conflict information when multiple packages have the same conflicts
  • Fix PackIcon blur background opacity issue

Test Plan

  • Select multiple uninstalled packages with conflicts - verify only conflicted packages appear in dialog
  • Select mix of installed/uninstalled packages - verify buttons are hidden with appropriate message
  • Select multiple packages with different statuses - verify correct priority status is shown
  • Select packages with import failures - verify status reflects the error state
  • Verify Total Nodes count correctly sums nodes from all selected packages

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

viva-jinyi and others added 2 commits August 20, 2025 15:52
@viva-jinyi @claude
feat: improve multi-package selection handling
0ca0aaa 
- Check each package individually for conflicts in install dialog
- Show only packages with actual conflicts in warning dialog
- Hide action buttons for mixed installed/uninstalled selections
- Display dynamic status based on selected packages priority
- Deduplicate conflict information across multiple packages
- Fix PackIcon blur background opacity

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@viva-jinyi @claude
refactor: extract multi-package logic into reusable composables
e19c45a 
- Create usePackageSelection composable for installation state management
- Create usePackageStatus composable for status priority logic
- Refactor InfoPanelMultiItem to use new composables
- Reduce component complexity by separating business logic
- Improve code reusability across components

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@viva-jinyi viva-jinyi self-assigned this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yorha4D Yorha4D Awaiting requested review from Yorha4D Yorha4D will be requested when the pull request is marked ready for review Yorha4D is a code owner

@KarryCharon KarryCharon Awaiting requested review from KarryCharon KarryCharon will be requested when the pull request is marked ready for review KarryCharon is a code owner

@shinshin86 shinshin86 Awaiting requested review from shinshin86 shinshin86 will be requested when the pull request is marked ready for review shinshin86 is a code owner

Assignees

@viva-jinyi viva-jinyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@viva-jinyi