Use @inline to replace @lazy where possible #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianSpeitel
force-pushed
the
lazy-inline
branch
from
22c75fa to
f83bdeb
Compare
SebastianSpeitel
commented
May 6, 2021
| "test": "asp --verbose --nologo && npm run test:empty", | ||
| "pretest:empty": "npm run asbuild:empty", |
There was a problem hiding this comment.
Why does this work, you may ask.
pre and post hooks can be added to any npm script by just prefixing it with pre or post.
https://docs.npmjs.com/cli/v7/using-npm/scripts#pre--post-scripts
|
Since this now tests an optimized build, even neither inlining nor marking as @lazy will fail now, since binaryan omits unused variables during optimization. And not optimizing won't result in an empty output because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.