Skip to content

COLDBOX-1345 Resolve #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
Merged

COLDBOX-1345 Resolve #619

merged 1 commit into from
Aug 16, 2025

Conversation

jclausen
Copy link
Contributor

@jclausen jclausen commented Aug 15, 2025

Description

This commit for COLDBOX-1250: RestHandler.cfc should catch NotAuthorized exception
Resolved
was implemented incorrectly.

Authorization - deals with permissability
Authentication - deals with bad or no credentials

When cbSecurity throws the NotAuthorized exception it is in the context of a permissability check. As such, the exception is correctly named, but the method it calls is incorrect.

Jira Issues

https://ortussolutions.atlassian.net/browse/COLDBOX-1345

Type of change

Please delete options that are not relevant.

  • Bug Fix

Checklist

  • My code follows the style guidelines of this project cfformat
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jclausen jclausen requested a review from lmajano August 15, 2025 21:01
@jclausen
Copy link
Contributor Author

cc/ @GunnarLieb - this will change the status code when merged, in case you need to update any of your tests.

Copy link

github-actions bot commented Aug 15, 2025

Test Results

   42 files  ±0    936 suites  ±0   7m 30s ⏱️ -2s
1 248 tests ±0  1 247 ✅ ±0    1 💤 ±0  0 ❌ ±0 
7 308 runs  ±0  6 870 ✅ ±0  438 💤 ±0  0 ❌ ±0 

Results for commit 521a89c. ± Comparison against base commit fb2f53a.

♻️ This comment has been updated with latest results.

@lmajano lmajano merged commit 53f3086 into development Aug 16, 2025
19 checks passed
@lmajano lmajano deleted the patch/COLDBOX-1345 branch August 16, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants