Disable Rich tracebacks by default #6576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich logging is trading usability for the "nice look". We don't want that as a default experience.
Jackenmen
added
the
Type: Enhancement
github-actions
bot
added
the
Category: Core - Command-line Interfaces
Jackenmen
force-pushed
the
disable_rich_logging_by_default
branch
from
6786d8f to
6b0ff85
Compare
|
One could argue that, since this is marked as useful for development, maybe we should auto-enable it as part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Rich tracebacks trade usability for the "nice look". We don't want that as a default experience. It's been a constant support nightmare due to how much it inflates the text length of tracebacks, doesn't react well to terminal resizing, and, empirically, probably also slows down console logging noticeably...
I feel like this has been a known "ah, yes, this does kinda suck and we'd like to change it at some point" for a while.
Have the changes in this PR been tested?
Yes