Support max_python_version key in info.json #5594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Docs - Other
Vexed01
reviewed
Aug 9, 2022
There was a problem hiding this comment.
I have tested this and can confirm it works as I described in #5590. In the process of testing I noticed the plural/singluar string selection doesn't actually function in the new code and in the min version code - see suggestions.
Co-authored-by: Vexed <[email protected]>
Co-authored-by: Vexed <[email protected]>
|
@Vexed01 i applied the patches you gave in the suggestions. |
|
ensure_max_python_version_info Can probably be simplified to 3,10 as micro versions shouldn't have any breaking changes. |
Jackenmen
force-pushed
the
V3/feature/max_python_version
branch
from
b4cd663 to
3dca02c
Compare
Jackenmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Make cogs be able to have a maximum python version incase a new version has a change that breaks that cog. (#5590)