removed whitespace #113
removed whitespace #113
Conversation
also added empty comments for readability.
DaricusDuncan
requested review from
niccokunzmann
and removed request for
niccokunzmann
| @@ -18,120 +18,126 @@ | |||
| <link type="text/css" rel="stylesheet" href="../css/Ubuntu.css" media="screen"/> | |||
| <link rel="shortcut icon" href="../favicon.ico?v=2" type="image/x-icon"> | |||
| <meta charset="utf-8"> | |||
| <title>{{ page.title | escape }} - {{ site.data.localization.title[page.lang] }}</title> | |||
| <title>{{- page.title | escape -}} - {{- site.data.localization.title[page.lang] -}}</title> | |||
There was a problem hiding this comment.
Here, the spaces have visual meaning in the title
| </script> | ||
| <style> | ||
| .clicked .toggle-hint:before { | ||
| content: "{{ site.data.localization.hint.shown[page.lang] }}"; | ||
| content: "{{- site.data.localization.hint.shown[page.lang] -}}"; |
There was a problem hiding this comment.
Here, this is not needed but also ok.
| {% if p.lang == page.lang %} | ||
| {% assign step_index = step_index | plus: 1 %} | ||
| {% if p_topic == topic and same_topic_started == false %} | ||
| {% comment %}{% endcomment %} |
There was a problem hiding this comment.
I do not know what this line is for.
| {%- assign has_next_page = false -%} | ||
| {%- assign step_index = 0 -%} | ||
| {%- assign next_page = nil -%} | ||
| {%- for p in site.pages -%} |
There was a problem hiding this comment.
These are the lines which make the file so much bigger.
| {%- assign same_topic_started = false -%} | ||
| {%- endif -%} | ||
| <a id="page-{{- p.path -}}" class="step {%- if page == p -%}current{%- endif -%}" href="..{{- p.url -}}">{%- if page == p -%}{{- step_index -}}{%- endif -%}</a> | ||
| {% comment %}{% endcomment %} |
There was a problem hiding this comment.
I do not know why you put the comment there. Could you elaborate?
| {% endif %} | ||
| {{- content -}} | ||
| {%- if has_next_page -%} | ||
| <a href="..{{- next_page.url -}}" class="next-page">{{- site.data.localization.footer.nextStep[page.lang] -}}</a> |
There was a problem hiding this comment.
Adding the - has no effect here. Did you do it for consistency?
There was a problem hiding this comment.
This reply will be a reply to all the threads here. When editing the layout file, I did two things:
- I search-replaced the following strings:
"{{ " --> "{{- ""{% " --> "{%- "" }}" --> " -}}"" %}" --> " -%}"
This took out all the whitespace between elements. However, it does not save indentation, as you requested in the solution:
Please use this to reduce the number spaces.
When you do that, please keep the indentation intact - each element should be on a new line.
Taking out all the whitespace put each <a> in the <header> on the same line. I had to add some space back so that each <a> had its own line.
- I added comments to make spaces after certain html elements inside the
<header>.
Before these changes, the page source looked like this: view-source:https://coderdojopotsdam.github.io/regex-tutorial/en/00-01.html?
After the changes, the page source looked like this: view-source:https://undoingtech.github.io/regex-tutorial/en/00-01.html?
Note: I cannot provide a link directly to the source code, so you will have to view it yourself after you click on the link.
|
@undoingtech Thanks for your pull request! I added some comments. What do you think? I merged it so we have the improvements right away. |
|
I found another bug #114. Would you like to review which spaces need removal and which do not?
|
Added dashes to remove whitespace.
Also added empty comments {% comment %}{% endcomment %} for readability.