Skip to content

feat(VibeBuilder): [LXP-8087] add 3 builder illustrations #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(VibeBuilder): [LXP-8087] add 3 builder illustrations #3210

wants to merge 5 commits into from
+838 −0

Conversation

@saghdaey
Copy link
Contributor

@saghdaey saghdaey commented Nov 12, 2025 •
edited
Loading

Overview

Adds three new illustrations related to the VibeBuilder

  • VibeBuilder
  • VibeBuilderPromotion
  • VibeBuilderComputer

PR Checklist

Testing Instructions

In the storybook preview, visit gamut illustrations and see the three new ones:
VibeBuilder, VibeBuilderComputer, and VibeBuilderPromotion

eg:

Screenshot 2025-11-12 at 5 18 14 PM

Don't make me tap the sign.
Figma which includes the new illustrations:
https://www.figma.com/design/2TcDi9btl8VqWTydsT9KsR/2.0-Discovery?node-id=235-22763&m=dev

  1. Visit gamut illustrations in the preview env: https://6914ed1ff813a218b3215f86--gamut-preview.netlify.app/?path=/docs/atoms-illustrations--docs
  2. In the illustration preview, look at each of the 3 new illustrations:
  • VibeBuilder
  • VibeBuilderComputer
  • VibeBuilderPromotion
  1. Approve if they look correct!

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit cf03bf4

☁️ Nx Cloud last updated this comment at 2025-11-12 20:22:31 UTC

@codecademydev
Copy link
Collaborator

codecademydev commented Nov 12, 2025

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

🚀 Styleguide deploy preview ready!

Preview URL: https://6914ed1ff813a218b3215f86--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/6914ed1ff813a218b3215f86

@saghdaey saghdaey marked this pull request as ready for review November 12, 2025 22:16
@saghdaey saghdaey requested a review from a team as a code owner November 12, 2025 22:16
@saghdaey saghdaey requested a review from dreamwasp November 12, 2025 22:16
LinKCoding
LinKCoding reviewed Nov 13, 2025
View reviewed changes
packages/gamut-illustrations/src/VibeBuilderPromotion.tsx

import { IllustrationProps } from './types';

export const VibeBuilderPromotion: React.FC<IllustrationProps> = ({
Copy link
Contributor

@LinKCoding LinKCoding Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I noticed when playing around with light/dark mode (though it does seem like these images were only intended for light mode)

In light mode, the hook below the project screen just blends in

Image

whereas in dark mode, it is included

Image

Not sure if this is intentional and it's very minor, but just wanted to mention it.

Copy link
Contributor Author

@saghdaey saghdaey Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch thanks Kenny! I'll share with Aashna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinKCoding LinKCoding LinKCoding left review comments

@irenerobb72 irenerobb72 Awaiting requested review from irenerobb72

@dreamwasp dreamwasp Awaiting requested review from dreamwasp dreamwasp is a code owner automatically assigned from Codecademy/gamut

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saghdaey @codecademydev @LinKCoding