Skip to content

Updating cybersecurity.md #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 31, 2023
Merged

Updating cybersecurity.md #3704

merged 14 commits into from
Oct 31, 2023

Conversation

@Ashu104
Copy link
Contributor

@Ashu104 Ashu104 commented Oct 22, 2023 •
edited
Loading

Description

new documentation changes are made which are really important in order to provide quality and quantity to userbase of codecademy.

Type of Change

these are some relevant documentation changes

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Ashu104
Copy link
Contributor Author

Ashu104 commented Oct 22, 2023

hey @SSwiniarski
could you please review and merge my pr.

SSwiniarski
SSwiniarski suggested changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashu104 I reviewed this and had some comments.

@SSwiniarski SSwiniarski self-assigned this Oct 22, 2023
@Ashu104
Copy link
Contributor Author

Ashu104 commented Oct 22, 2023

@Ashu104 I reviewed this and had some comments.

@SSwiniarski thanks for reviews and suggestion. I've made some changes as you mentioned. pls have a look on them.

@Ashu104 Ashu104 requested a review from SSwiniarski October 22, 2023 18:22
@Ashu104 Ashu104 changed the title Updating cybersecurity.md and subjects.md Updating cybersecurity.md Oct 22, 2023
@Ashu104
Revert "Delete documentation/subjects.md"
332a87d 
reverting change
This reverts commit 2f43929.
SSwiniarski
SSwiniarski suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashu104 we cannot merge this because you deleted the subjects.md file. You need to replace it with the original copy.

@Ashu104 Ashu104 requested a review from SSwiniarski October 23, 2023 18:34
@Ashu104
Copy link
Contributor Author

Ashu104 commented Oct 23, 2023

@Ashu104 we cannot merge this because you deleted the subjects.md file. You need to replace it with the original copy.
Hey @SSwiniarski
Im very sorry for that, now I've revert my change and rewrite pr as only change in cybersecurity.md file.
could you pls consider it once.

SSwiniarski
SSwiniarski approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashu104 I made a minor change and it looks good for a second review.

@Ashu104 Ashu104 requested a review from SSwiniarski October 26, 2023 18:12
caupolicandiaz
caupolicandiaz approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashu104 @SSwiniarski I just made a few minor language updates. LGTM

@caupolicandiaz caupolicandiaz added status: review 2️⃣ completed hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest and removed status: ready for next review labels Oct 30, 2023
@SSwiniarski SSwiniarski merged commit 6b5f65d into Codecademy:main Oct 31, 2023
@github-actions
Copy link

github-actions bot commented Oct 31, 2023

👋 @Ashu104
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cybersecurity

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SSwiniarski SSwiniarski Awaiting requested review from SSwiniarski

1 more reviewer

@caupolicandiaz caupolicandiaz caupolicandiaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SSwiniarski SSwiniarski

Labels

cybersecurity Cybersecurity entries enhancement New feature or request hacktoberfest hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ashu104 @CLAassistant @caupolicandiaz @SSwiniarski