[Feature] Application form for study participation #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Dec 8, 2020
saseungmin
commented
- 스터디 신청할 때 신청서를 받기 위해 모달창으로 스터디 신청서 작성 폼을 구현
- Implementation of the study participation application form as a modal window
saseungmin
commented
Dec 8, 2020
Comment on lines
+215
to
+217
| // TODO: 이 부분은 추후 변경해야된다 현재 스터디 참여 신청서 모달창이 나타남. | ||
| fireEvent.click(getByText('확인')); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
- 현재 완전한 기능을 구현하지 않아서 이 부분은 변경해줘야 된다.
Comment on lines
+91
to
+92
| // TODO: 이 부분은 추후 수정해야된다. 현재 스터디 참여 신청서 모달창으로 인해 테스트 fail되기 때문에 변경해놈 | ||
| fireEvent.click(getByText('확인')); |
Collaborator
Author
There was a problem hiding this comment.
- 이 부분도 마찬가지로 테스트가 현재 깨지기 때문에 임시로 모달창이 넘어가게 해놨음
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.