Skip to content

[Refactoring] Refactoring through code review #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2020
Merged

[Refactoring] Refactoring through code review #46

merged 2 commits into from
Nov 30, 2020

Conversation

@saseungmin
Copy link
Collaborator

@saseungmin saseungmin commented Nov 30, 2020 •
edited
Loading

  • useEffect를 사용한 언마운트(clean up)에서 react-use의 unmount hook으로 변경
  • npm install react-use

@saseungmin
[Refactoring] Refactoring through code review
ee2ae1c 
- Changed from useEffect for unmount to unmount hook
- npm install react-use
@saseungmin saseungmin added the refactoring 리팩토링 수정사항 수정 label Nov 30, 2020
@saseungmin saseungmin merged commit 479f596 into CodeSoom:main Nov 30, 2020
@saseungmin saseungmin mentioned this pull request Nov 30, 2020
Closed
20 tasks
@saseungmin saseungmin deleted the refactoring-through-code-review branch July 5, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactoring 리팩토링 수정사항 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saseungmin