Improve css style for study introduce page #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve css style for study introduce page
saseungmin
commented
Nov 21, 2020
Comment on lines
+94
to
+119
| <IntroduceHeaderWrapper> | ||
| <h1>{title}</h1> | ||
| <button type="button">신청하기</button> | ||
| </IntroduceHeaderWrapper> | ||
| <ModeratorWrapper> | ||
| {`🙋♂️ ${moderatorId}`} | ||
| </ModeratorWrapper> | ||
| <IntroduceReferenceWrapper> | ||
| <IntroduceReference> | ||
| <label htmlFor="application-status">신청 현황 :</label> | ||
| <span id="application-status"> | ||
| {`${participants.length} / ${personnel}`} | ||
| </span> | ||
| </IntroduceReference> | ||
| <IntroduceReference> | ||
| <label htmlFor="apply-end">접수 마감 일자 :</label> | ||
| <span id="apply-end">{applyEndDate}</span> | ||
| </IntroduceReference> | ||
| </IntroduceReferenceWrapper> | ||
| <IntroduceContentTitle> | ||
| 소개 | ||
| </IntroduceContentTitle> | ||
| {/* TODO: dangerouslySetInnerHTML으로 변경하기 */} | ||
| <IntroduceContent> | ||
| {contents} | ||
| </IntroduceContent> |
Collaborator
Author
There was a problem hiding this comment.
- Refactoring이 필요할 듯 하다.
- 컴포넌트 분리하기.
Comment on lines
+24
to
+38
| button { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| margin: .5rem 0 .5rem 0; | ||
| padding: 0.25rem 5rem; | ||
| font-size: 1.5em; | ||
| line-height: 0; | ||
| font-family: 'Gamja Flower', cursive; | ||
| border-radius: 0.4rem; | ||
| border: none; | ||
| background: ${palette.teal[5]}; | ||
| color: white; | ||
| &:hover{ | ||
| background: ${palette.teal[4]}; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
- 버튼은 공통으로 분리하기 (TODO)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 진행 사항