Skip to content

Autocomplete Feature #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Autocomplete Feature #282

wants to merge 12 commits into from

Conversation

FastestMolasses
Copy link
Member

Description

Adds the first iteration of the autocomplete feature.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@FastestMolasses FastestMolasses marked this pull request as ready for review December 29, 2024 13:12
@dankinsoid
Copy link

@FastestMolasses hi! I forked from your branch and found a crash:
StyledRangeStore+Internals.swift line 44
_guts[_guts.index(after: index)] fails with out of bounds error

this check fixes:
let nextIndex = _guts.index(after: index)
guard nextIndex < _guts.endIndex else { return }

@FastestMolasses
Copy link
Member Author

This might have been a bug that was fixed in a later commit. I'll merge main into this soon and check it out, this PR is currently on hold until the Language Server Installation PR gets merged.

@tom-ludwig
Copy link
Member

Hey @FastestMolasses was the status on the PR? Is it still up for review?

austincondiff
austincondiff previously approved these changes May 30, 2025
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just merge the conflicts.

@thecoolwinter
Copy link
Collaborator

@FastestMolasses hi! I forked from your branch and found a crash: StyledRangeStore+Internals.swift line 44 _guts[_guts.index(after: index)] fails with out of bounds error

this check fixes: let nextIndex = _guts.index(after: index) guard nextIndex < _guts.endIndex else { return }

@FastestMolasses is right, this was due to another component in the editor, which I believe I fixed.

@thecoolwinter
Copy link
Collaborator

@FastestMolasses is this just waiting for a parameter to be able to pass in a suggestion delegate? I'd be happy to fill that out if that's all that's left.

@FastestMolasses
Copy link
Member Author

There's still the bug with the file contents not being updated. I have some refactors that fixes a few issues, I'll commit that and request reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants