Skip to content

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Aug 28, 2025

Description

Updates the toolbar for macOS Tahoe. All changes in this PR should not affect existing functionality or design.

Related Issues

Checklist

  • Navigator extends to the top of the toolbar.
  • Task start/stop buttons in group.
  • Toolbar no longer compact (taller)
  • Extra padding on branch picker.
  • Activity viewer no longer has a background color.
  • Schema select hover is rounded.
  • Task select hover is rounded.
  • Activity viewer padding.
  • Task status padding too short.
  • Task status animation slightly wrong.
  • Notifications and activity viewer are combined in one glass item.
  • Notification item keeps space when hidden.
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

All toolbar sta
Screenshot 2025-08-29 at 4 33 01 PM
Screenshot 2025-08-29 at 4 32 57 PM
Screenshot 2025-08-29 at 4 32 44 PM
Screenshot 2025-08-29 at 4 32 36 PM
tes:

Compression

Screen.Recording.2025-08-29.at.4.33.20.PM.mov

Toolbar in action

Screen.Recording.2025-08-29.at.4.30.35.PM.mov

Popovers

Screen.Recording.2025-08-29.at.11.58.48.AM.mov

Task notification viewer

Screen.Recording.2025-08-29.at.12.23.59.PM.mov

@thecoolwinter thecoolwinter added enhancement New feature or request macOS Tahoe Issues for macOS Tahoe labels Aug 28, 2025
@jacob-carlborg
Copy link

Looking at the images, the bottom line of the toolbar is not aligned with the line in the sidebar and in the inspector. It's not a straight line across the toolbar and the sidebars. Is that something that Apple's frameworks are rendering or CodeEdit?

@SilverMarcs
Copy link

It seems the toolbar has significantly longer height than it should have

@thecoolwinter
Copy link
Collaborator Author

Looking at the images, the bottom line of the toolbar is not aligned with the line in the sidebar and in the inspector. It's not a straight line across the toolbar and the sidebars. Is that something that Apple's frameworks are rendering or CodeEdit?

It's a bit of both. The built-in toolbar no longer has a set size across each so we'll probably follow Xcode's lead and change it up. That's not actually a part of the toolbar in CE though, so it'll be a different PR.

@thecoolwinter
Copy link
Collaborator Author

It seems the toolbar has significantly longer height than it should have

It's larger now but it also looks significantly larger because we have some hard-coded top padding in components that will need to be updated.

@SilverMarcs
Copy link

It seems the toolbar has significantly longer height than it should have

It's larger now but it also looks significantly larger because we have some hard-coded top padding in components that will need to be updated.

May I ask which components need this top padding removed?

@thecoolwinter
Copy link
Collaborator Author

It seems the toolbar has significantly longer height than it should have

It's larger now but it also looks significantly larger because we have some hard-coded top padding in components that will need to be updated.

May I ask which components need this top padding removed?

It should be the EditorLayoutView iirc and I think there's some in the navigator code. tbh I haven't looked into it yet.

@thecoolwinter
Copy link
Collaborator Author

Ah shoot, you're totally right it is the toolbar making that space...

Screenshot 2025-08-29 at 12 44 19 PM

@thecoolwinter
Copy link
Collaborator Author

Good catch, figured it out. Can't use the .unified toolbar style it has to be .automatic.

@thecoolwinter
Copy link
Collaborator Author

Well that unified to default change led to a whole slew of bugs but I think this is ready to go!

@thecoolwinter thecoolwinter marked this pull request as ready for review August 29, 2025 21:37
@SilverMarcs
Copy link

Yeah size seems perfect now. But the toolbar background is getting this transparent effect from the tahoe default toolbar styling.
I'd assume .scrollEdgeEffectStyle(.hard) could help but couldn't get that to work

2025-08-30_07-12-29

@thecoolwinter
Copy link
Collaborator Author

Yeah size seems perfect now. But the toolbar background is getting this transparent effect from the tahoe default toolbar styling.

I'd assume .scrollEdgeEffectStyle(.hard) could help but couldn't get that to work

2025-08-30_07-12-29

Shoot! I forgot to double check it on dark mode. I'll take a look.

@thecoolwinter
Copy link
Collaborator Author

Okay two things with the transparency. It's inconsistent when it's that opaque on light mode, almost like it only remembers to do so after it's been changed from dark mode.

I think it's the right move to have it pretty transparent. But the gutter view is not having the glass effect applied to it for some reason... I'm going to see if I can fix that as a CESE issue and leave the transparency in the toolbar.

When I move on to tabs next I may explore making them sit on a glass element.

@thecoolwinter
Copy link
Collaborator Author

Okay yeah this is partly a liquid glass bug. It's not applying the glass styling to floating scrollview views. I'll submit a feedback and then we'll need to consider how to move forward. Probably making the toolbar less opaque.

@SilverMarcs
Copy link

Usually it applies the blurring to SwiftUI scrollviews or lists automatically but Im guessing the underlying codeeditorview is far from swiftui.
Also, I’d say its fine for the toolbar to be opaque, similar to Xcode 26 since there are elements like tabviww and jumpbar below it

@thecoolwinter
Copy link
Collaborator Author

Yeah it appears that the liquid glass effect just doesn't apply to floating scrollview views. I've submitted a feedback for it, we may just have to clip the gutter to the visible area for now. And yeah the editor view isn't SwiftUI it's mostly AppKit.

@austincondiff
Copy link
Collaborator

What if we added a layer underneath for now instead of clipping it?

@thecoolwinter
Copy link
Collaborator Author

thecoolwinter commented Sep 2, 2025

What if we added a layer underneath for now instead of clipping it?

Good thought, I can try it

@thecoolwinter
Copy link
Collaborator Author

It looks great on the tab bar but the gutter still overflows everything. I'm really not sure how to move forwards with it. Same is true of the minimap divider view, glass just completely ignores it no matter what.

@thecoolwinter
Copy link
Collaborator Author

Screenshot 2025-09-02 at 12 45 32 PM

There's a second bug going on here too where again the toolbar sometimes just forgets to apply the glass effect to anything like in this screen cap. This is frustrating to work with

@thecoolwinter
Copy link
Collaborator Author

Screenshot 2025-09-02 at 12 46 37 PM

After a little messing around it remembers, but the gutter and minimap dividers are still unaffected.

@thecoolwinter
Copy link
Collaborator Author

Alright finally got an under-toolbar visual effect item to work! And it seems to have fixed the bug or at least made it unnoticeable. It is noticeable that it isn't glass, but maybe we can figure out a fix from CESE's side of things with the gutter view and minimap view.

@thecoolwinter
Copy link
Collaborator Author

Screenshot 2025-09-02 at 2 39 39 PM Screenshot 2025-09-02 at 2 39 21 PM

@thecoolwinter
Copy link
Collaborator Author

I did originally have glass instead of a plain visualeffectview, but glass has a deactivated state that makes it obvious we're injecting something behind the toolbar. Maybe we can subclass NSGlassEffectView and change that but this works.

@thecoolwinter thecoolwinter merged commit e298776 into main Sep 15, 2025
1 of 2 checks passed
@thecoolwinter thecoolwinter deleted the feat/tahoe-toolbar branch September 15, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request macOS Tahoe Issues for macOS Tahoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Can't Compile With Swift 6.2
4 participants