Skip to content

Fix namespaces for testing classes #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix namespaces for testing classes #78

merged 1 commit into from
Dec 1, 2020

Conversation

@peter279k
Copy link
Contributor

@peter279k peter279k commented Nov 30, 2020

What I did

  • Improving the testing class namespaces for tests/Unit/Xml/SoapXmlTest.php and tests/Unit/Xml/XmlSerializerTest.php.
    And it should let these classes be compatible with PSR-4 autloading.

@CodeDredd CodeDredd added the chore Maintance label Dec 1, 2020
@CodeDredd CodeDredd self-assigned this Dec 1, 2020
@CodeDredd CodeDredd self-requested a review December 1, 2020 13:23
CodeDredd
CodeDredd approved these changes Dec 1, 2020
View reviewed changes
Copy link
Owner

@CodeDredd CodeDredd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it !

@CodeDredd CodeDredd merged commit 5109fc8 into CodeDredd:master Dec 1, 2020
@peter279k peter279k deleted the test_enhancement branch December 1, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeDredd CodeDredd CodeDredd approved these changes

Assignees

@CodeDredd CodeDredd

Labels

chore Maintance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peter279k @CodeDredd