[BREAKING CHANGE] Support laravel 8 (again - sorry!) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@ohnotnow thx again for the PR. I think it doesn-t need a doc update because its only dependecy update. I start a new 2.x release and will make a v1 branch to have track there. i will drop laravel 8 support in v1 branch after that. |
CodeDredd
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The last PR allowed illuminate/support v8 - but I hadn't spotted that a full Laravel 8 install also needed the
php-http/guzzle-adaptorbumped to the-7package. Which is a bit annoying - but there we go. I think this is a breaking change as you can't install the -7 adapter on Laravel < 8.What I did
Changed the
php-http/guzzle6-adaptertophp-http/guzzle7-adapter.How to test
phpunit & a
laravel new test-soapand then do acomposer require codedredd/laravel-soap. Currently fails without bumping to the guzzle7 adapter.I wasn't sure whether to write up the docs if this become a 'v2.x' or not. I can add them into the PR if that's what will be happening though.