Skip to content

Arguments are parsed from body instead of xmlContent #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Arguments are parsed from body instead of xmlContent #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9778169
Arguments are parsed from body instead of xmlContent
bastien-phi Mar 2, 2022
a6b1f7b
Add test for Request::argument
bastien-phi Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public function xmlContent(): string
*/
public function arguments(): array
{
$doc = Document::fromXmlString($this->xmlContent());
$doc = Document::fromXmlString($this->body());
$method = $doc->locate(new SoapBodyLocator())?->firstElementChild;

return Arr::wrap(Arr::get(element_decode($method, traverse(new RemoveNamespaces())), 'node', []));
Expand Down
13 changes: 13 additions & 0 deletions tests/Unit/SoapClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,19 @@ public function testSoapWithDifferentHeaders($header, $exspected): void
Soap::assertActionCalled('GetWeatherInformation');
}

public function testArgumentsCanBeCalledTwice(): void
{
Soap::fake();
Event::fake();
Soap::assertNothingSent();
$response = Soap::baseWsdl(dirname(__DIR__, 1).'/Fixtures/Wsdl/weather.wsdl')
->call('GetWeatherInformation');
self::assertTrue($response->ok());
Soap::assertSent(function (Request $request) {
return $request->arguments() === $request->arguments();
});
}

public function soapHeaderProvider(): array
{
$header = [
Expand Down