Skip to content

chore: code clean up #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021
Merged

chore: code clean up #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3e5b4
chore: code clean up
CodeDredd Mar 29, 2021
10056ea
Apply fixes from StyleCI (#119)
CodeDredd Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Facades/Soap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @method static \CodeDredd\Soap\SoapClient stub(callable $callback)
* @method static \CodeDredd\Soap\SoapClient buildClient(string $setup = '')
* @method static \CodeDredd\Soap\SoapClient byConfig(string $setup = '')
* @method static \CodeDredd\Soap\SoapClient options(array $options)
* @method static \CodeDredd\Soap\SoapClient withOptions(array $options)
* @method static \CodeDredd\Soap\SoapClient handlerOptions(array $options)
* @method static \CodeDredd\Soap\SoapClient withWsse(array $config)
* @method static \CodeDredd\Soap\SoapClient withWsa()
Expand Down
4 changes: 2 additions & 2 deletions src/SoapClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
use CodeDredd\Soap\Exceptions\NotFoundConfigurationException;
use CodeDredd\Soap\Exceptions\SoapException;
use CodeDredd\Soap\Middleware\WsseMiddleware;
use GuzzleHttp\Client;
use GuzzleHttp\HandlerStack;
use Http\Adapter\Guzzle7\Client;
use Http\Client\Exception\HttpException;
use Illuminate\Contracts\Validation\Validator;
use Illuminate\Support\Str;
Expand Down Expand Up @@ -132,7 +132,7 @@ function (Request $request, array $options) {
protected function setHandler(HandlerInterface $handler = null)
{
$this->handler = $handler ?? HttPlugHandle::createForClient(
Client::createWithConfig($this->handlerOptions)
new Client($this->handlerOptions)
);
$this->addMiddleware();

Expand Down
5 changes: 2 additions & 3 deletions src/SoapFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
namespace CodeDredd\Soap;

use Closure;
use CodeDredd\Soap\Client\Request;
use CodeDredd\Soap\Client\ResponseSequence;
use function GuzzleHttp\Promise\promise_for;
use GuzzleHttp\Promise\Create;
use GuzzleHttp\Psr7\Response as Psr7Response;
use Illuminate\Support\Str;
use Illuminate\Support\Traits\Macroable;
Expand Down Expand Up @@ -216,7 +215,7 @@ public static function response($body = null, $status = 200, $headers = [])
]);
}

return promise_for(new Psr7Response($status, $headers, $body));
return Create::promiseFor(new Psr7Response($status, $headers, $body));
}

/**
Expand Down