AbusedClient::__doRequest Argument #5 ($oneWay) type error

[brianfy1]

• Laravel v8.31.0
• laravel-soap v2.0.0-beta.3
• WSDL Example file: http://www.dneonline.com/calculator.asmx?wsdl

I did install your package (v2.0.0-beta.3) and wanted to give it a quick run.
But I immediately running into this error.

Error Message:

Phpro\SoapClient\Soap\HttpBinding\SoapRequest::__construct(): Argument #5 ($oneWay) must be of type int, bool given, called in /home/vagrant/code/vendor/codedredd/laravel-soap/src/Driver/ExtSoap/AbusedClient.php on line 23

Routes:

// routes/web.php

use Illuminate\Support\Facades\Route;

Route::get('/', function () {
    $response = CodeDredd\Soap\Facades\Soap::baseWsdl('http://www.dneonline.com/calculator.asmx?wsdl')
        ->call('Add', [
            'intA', 4,
            'intB', 5
        ]);

    return $response;
});

Packages:

// composer.json
{
    "name": "laravel/laravel",
    "require": {
        "php": "^7.3|^8.0",
        "fideloper/proxy": "^4.4",
        "fruitcake/laravel-cors": "^2.0",
        "guzzlehttp/guzzle": "^7.0.1",
        "laravel/framework": "^8.12",
        "laravel/tinker": "^2.5",
        "codedredd/laravel-soap": "^2",
        "ext-soap": "*"
    },
    "require-dev": {
        "barryvdh/laravel-debugbar": "^3.5",
        "facade/ignition": "^2.5",
        "fakerphp/faker": "^1.9.1",
        "laravel/homestead": "^12.1",
        "laravel/sail": "^1.0.1",
        "mockery/mockery": "^1.4.2",
        "nunomaduro/collision": "^5.0",
        "phpunit/phpunit": "^9.3.3"
    }
}

Caused by this file

// CodeDredd/Soap/Driver/ExtSoap/AbusedClient.php

declare(strict_types=1);

namespace CodeDredd\Soap\Driver\ExtSoap;

use Phpro\SoapClient\Soap\Driver\ExtSoap\AbusedClient as PhproAbusedClient;
use Phpro\SoapClient\Soap\Driver\ExtSoap\ExtSoapOptions;
use Phpro\SoapClient\Soap\HttpBinding\SoapRequest;
use Phpro\SoapClient\Xml\SoapXml;

class AbusedClient extends PhproAbusedClient
{
    public static function createFromOptions(ExtSoapOptions $options): PhproAbusedClient
    {
        return new self($options->getWsdl(), $options->getOptions());
    }

    public function __doRequest($request, $location, $action, $version, $oneWay = 0)
    {
        $xml = SoapXml::fromString($request);
        $action = $action ?? $xml->getBody()->firstChild->localName;
        $this->storedRequest = new SoapRequest($request, $location, $action, $version, $oneWay);  // <-- line 23

        return $this->storedResponse ? $this->storedResponse->getResponse() : '';
    }
}

I'm still new to SOAP.
Does it require to feed Soap::baseWsdl()->call() with more options to make it pass?

[CodeDredd]

Hey, sorry for the late answer. I tried it out and couldn't reproduce the error. Which php version are you using?

[brianfy1]

Running php v8.0.1, using Laravel Homestead as my dev environment.

vagrant@box:~/code$ php -v
Xdebug: [Config] The setting 'xdebug.remote_connect_back' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_connect_back (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_log' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_log (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_port' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_port (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
PHP 8.0.1 (cli) (built: Jan 13 2021 08:22:35) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.1, Copyright (c), by Zend Technologies
    with Xdebug v3.0.2, Copyright (c) 2002-2021, by Derick Rethans
vagrant@box:~/code$

Using the latest hometead (stable) version

$ vagrant box update
==> box: Checking for updates to 'laravel/homestead'
    box: Latest installed version: 11.0.0
    box: Version constraints: >= 11.0.0, < 12.0.0
    box: Provider: virtualbox
==> box: Box 'laravel/homestead' (v11.0.0) is running the latest version.

[brianfy1]

Thank you for the hint about the version.
Switching (back) to php v7.4.14 solved it apparently.

[bastien-phi]

I'm having the same issue here.

Under php 8.0, $oneWay is a boolean in CodeDredd\Soap\Driver\ExtSoap\AbusedClient::__doRequest (\SoapClient::__doRequest was changed https://www.php.net/manual/en/soapclient.dorequest)

Phpro\SoapClient\Soap\HttpBinding\SoapRequest expects an interger for $oneWay

As made in Phpro\SoapClient\Soap\Driver\ExtSoap\AbusedClient, CodeDredd\AbusedClient should create a SoapRequest with $this->storedRequest = new SoapRequest($request, $location, $action, $version, (int) $oneWay);

I fixed the issue locally with this simple cast.

I'll try to make a PR for this next week but feel free to do it if you want !

[CodeDredd]

Your right. The cast does the trick. Phpro does it the same way. Thanks. Making an PR.

[bastien-phi]

Thanks for the fix and the release ! 😀

[brianfy1]

Thanks as well from my side!