Introduce PreviousValidators and fix tendermint bugs #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sgkim126
previously approved these changes
Dec 28, 2019
PreviousValidators represent the list of validators whose signatures should be included in this block. Its value is the same as the CurrentValidators of the previous block's state, and the NextValidators of the grandparent block's state.
CurrentValidators was introduced to tendermint, but it wasn't used by some part of our implementation. This patch doesn't fix all of them, but important parts are filled in.
1th term open doesn't require any reward distribution since the 0th term is static validator consensus
remagpie
force-pushed
the
fix-tendermint
branch
from
cde08e3 to
451278d
Compare
sgkim126
approved these changes
Dec 31, 2019
majecty
approved these changes
Jan 2, 2020
|
@HoOngEe please review it. |
HoOngEe
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patches in #27 were originally ported from the CodeChain's snapshot branch, which includes CurrentValidators patch in CodeChain-io/codechain#1922. I found out that there was something wrong about the previous implementation, and introduced PreviousValidator state value to solve this.
It's almost the same as the CurrentValidators, except that it is updated with the values from CurrentValidators.
The fee calculation function is changed a bit to utilize this state value. Please take a look at it carefully.
Some other patches not related to the fee calculation are included too. A detailed explanation is written in the commit messages.