Follow-up patches for the tendermint consensus with snapshot sync #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remagpie
force-pushed
the
fix-tendermint
branch
from
b14a896 to
2da7ee0
Compare
sgkim126
previously approved these changes
Dec 27, 2019
Closed
majecty
previously approved these changes
Dec 27, 2019
CurrentValidators was introduced to tendermint, but it wasn't used by some part of our implementation. This patch doesn't fix all of them, but important parts are filled in.
1th term open doesn't require any reward distribution since the 0th term is static validator consensus
remagpie
force-pushed
the
fix-tendermint
branch
from
2da7ee0 to
ae8afc6
Compare
majecty
approved these changes
Dec 27, 2019
|
I think I'm a bit confused about the relation between signers and the state item |
sgkim126
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27 introduced a behavior change in the consensus implementation, and some additional problems were found while testing snapshot synchronization.
Detailed explanation is recorded in the commit messages.