Fix relayer to update each chain's light client successfully #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2020
Merged
junha1
reviewed
Mar 5, 2020
| } | ||
| Datagram::UpdateClient { | ||
| id, | ||
| header, |
Contributor
There was a problem hiding this comment.
Make the UpdateClient function use the correnct method name in log
->
Make the UpdateClient function use the correct method name in log
| }); | ||
| this.faucetAddress = config.faucetAddress; | ||
| this.counterpartyIdentifiers = config.counterpartyIdentifiers; | ||
| } |
Contributor
There was a problem hiding this comment.
If we send transactions without waiting for inclusion, Foundy can
create a block that has more than one transaction.
->
If we send transactions without waiting for inclusion, Foundry can
create a block that has more than one transaction.
Contributor
|
Please check cancelled CI actions |
majecty
force-pushed
the
f/ics-update-client
branch
from
d60c20e to
7ad236d
Compare
junha1
approved these changes
Mar 5, 2020
Contributor
|
@majecty Why do some of CI keep failing? |
We implement the light client only for dynamic validator. Because the static validator will be removed. Currently, the static validator is not removed yet. Only for this experimental branch, skip the verification of validator set.
In the IBC scenario, a chain can creates blocks faster than 1 block/sec. Since Foundry does not allow blocks with the same timestamp, we should make the chain slow. This commit should not be included in the master branch
* WAIT_1_SEC_BEFORE_CREATING_A_BLOCK It will make Tendermint spend more than a second to create a block. * BYPASS_VERIFICATION_IN_STATIC_VALIDATOR It will make the light client skip signature verification. Since we didn't make verification logic for the static validator set, we can't validate it now. The static validator set will be removed soon.
Relayer should run harder to update light clients if the chain creates block too fast. This commit will not affect consensus. This commit makes running the IBC scenario convenient.
Removing pending transactions helps to run chains with a reliable state
If we send transactions without waiting for inclusion, Foundry can create a block that has more than one transaction.
majecty
force-pushed
the
f/ics-update-client
branch
from
7ad236d to
8831e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.