Create snapshots #19
Merged
Create snapshots #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remagpie
force-pushed
the
create-snapshot
branch
2 times, most recently
from
139a6b7 to
1f47cee
Compare
sgkim126
requested changes
Dec 21, 2019
remagpie
force-pushed
the
create-snapshot
branch
4 times, most recently
from
5374ec3 to
472166f
Compare
sgkim126
requested changes
Dec 24, 2019
sgkim126
reviewed
Dec 24, 2019
remagpie
force-pushed
the
create-snapshot
branch
4 times, most recently
from
2b4afde to
72b69b6
Compare
remagpie
force-pushed
the
create-snapshot
branch
2 times, most recently
from
56218cd to
8bfc071
Compare
sgkim126
reviewed
Dec 26, 2019
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> { | ||
| match Node::decoded(&self.rlp) { | ||
| Some(node) => write!(f, "{:?}", &node), | ||
| None => write!(f, "{:?}", self.rlp), |
There was a problem hiding this comment.
When does it become None?
Is it normal that the rlp cannot be decoded?
There was a problem hiding this comment.
I'm not sure why this would happen.
It seems decoded returns None when the rlp is empty, but this should not be happening in the cases that I know of.
There was a problem hiding this comment.
Okay. Let's leave it for this PR and try to remove it in the next commit.
sgkim126
reviewed
Dec 26, 2019
sgkim126
reviewed
Dec 26, 2019
|
@foriequal0 Could you answer the questions above? |
This is a work-around to the currently order-dependant and non-deterministic initialization of Tendermint ConsensusEngine/Worker.
remagpie
force-pushed
the
create-snapshot
branch
from
8bfc071 to
e3865be
Compare
|
Let me merge it and fix in in the next commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collected from CodeChain-io/codechain#1869 and CodeChain-io/codechain#1875