Implement connOpenInit datagram in the ICS connection spec #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majecty
force-pushed
the
f/ics-poc-connection
branch
from
f26e693 to
52751f1
Compare
majecty
changed the title
6 tasks
junha1
reviewed
Feb 13, 2020
| }, | ||
| } | ||
|
|
||
| impl Encodable for Datagram { |
Contributor
Author
There was a problem hiding this comment.
I changed it. Could you check it again?
core/src/ibc/connection_03/types.rs
Outdated
| } | ||
|
|
||
| impl rlp::Encodable for ConnectionEnd { | ||
| fn rlp_append(&self, s: &mut rlp::RlpStream) { |
Contributor
There was a problem hiding this comment.
Did you check that RLP macro can handle this?
Contributor
Author
There was a problem hiding this comment.
Sure, I'll check them.
Contributor
Author
There was a problem hiding this comment.
I checked this code: https://github.com/CodeChain-io/rlp/blob/64fdbc5758e05483f62fae99521520f566eaca9d/rlp-derive/src/en.rs#L21
It seems it is suitable to use it. I'll try it.
Contributor
Author
There was a problem hiding this comment.
I changed it. Could you check it again?
majecty
force-pushed
the
f/ics-poc-connection
branch
from
52751f1 to
ffe6d73
Compare
majecty
force-pushed
the
f/ics-poc-connection
branch
from
ffe6d73 to
71c696c
Compare
junha1
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on
#122, #161Implement ICS connection issue: #156