Implement the errors of account RPC methods #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseo
reviewed
Aug 14, 2018
|
|
||
| impl SimpleSecretStore for KeyStore { | ||
| fn insert_account(&self, secret: Secret, password: &Password) -> Result<Address, Error> { | ||
| self.store.insert_account(secret, password) |
Member
There was a problem hiding this comment.
What does store.insert_account return when the account already exists?
Contributor
Author
There was a problem hiding this comment.
I guess it's a legacy from Parity, the store is KeyMultiStore. KeyMultiStore can store multiple accounts with different passwords for one address. In that case, the store allows the address to use if one of the passwords is given.
joojis
added a commit
to CodeChain-io/codechain-sdk-js
that referenced
this pull request
Aug 16, 2018
The account RPC error tests should resume after merging CodeChain-io/codechain#585
joojis
force-pushed
the
account-rpc-errors
branch
from
63847e2 to
3c6067a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.