Skip to content

Conversation

@foriequal0
Copy link
Contributor

@foriequal0 foriequal0 commented Aug 4, 2018

@majecty majecty requested review from majecty and sgkim126 August 4, 2018 03:52
@kseo
Copy link
Member

kseo commented Aug 4, 2018

@foriequal0 Please sign the CLA.

Copy link
Member

@kseo kseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the first patch is necessary because address is an abbreviation of socket_address.

@foriequal0
Copy link
Contributor Author

Okay. Should I append a commit or rewrite the history?

@foriequal0 foriequal0 force-pushed the feature/rpc-get-port branch from e083d33 to c5e7a3b Compare August 4, 2018 07:13
Copy link
Member

@kseo kseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants