Skip to content

Conversation

@kakao-jun-e
Copy link
Contributor

Fix #479

@kseo kseo requested review from ScarletBlue and remagpie July 25, 2018 08:41
spec/Stratum.md Outdated

## mining.authorize

Used for authorizing miner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miner -> miners

spec/Stratum.md Outdated

## mining.notify

Used for sending notifications with mining jobs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used for sending notifications with mining jobs -> Used for sending notifications regarding mining jobs.

spec/Stratum.md Outdated
```

## Exception Handling (DRAFT)
Stratum defines simple exception handling. Example of rejected share looks like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of rejected share looks like: -> Example of a rejected share looks like:

spec/Stratum.md Outdated
```

Where the error field is defined as (error_code, human_readable_message, traceback). Traceback may contain additional information for debugging errors.
Proposed error codes for mining service are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mining service -> mining services

spec/Stratum.md Outdated
}
```

Where the error field is defined as (error_code, human_readable_message, traceback). Traceback may contain additional information for debugging errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback may contain additional information about debugging errors.

Copy link
Contributor

@ScarletBlue ScarletBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some changes for descriptions.

@kakao-jun-e kakao-jun-e force-pushed the release/stratum_spec branch from bc83d78 to c270ebf Compare July 25, 2018 08:56
@kakao-jun-e
Copy link
Contributor Author

I've added "CLI options".

@kakao-jun-e kakao-jun-e force-pushed the release/stratum_spec branch from c270ebf to 7a49295 Compare July 25, 2018 11:15
Copy link
Member

@kseo kseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kseo kseo merged commit e50775a into CodeChain-io:master Jul 25, 2018
@kakao-jun-e kakao-jun-e deleted the release/stratum_spec branch July 25, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants