Cleanups in the snapshot sync #1921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remagpie
previously approved these changes
Dec 9, 2019
remagpie
previously approved these changes
Dec 9, 2019
sgkim126
reviewed
Dec 9, 2019
sgkim126
reviewed
Dec 9, 2019
sgkim126
reviewed
Dec 9, 2019
| client.add_notify(Arc::downgrade(&self.chain_notify) as Weak<dyn ChainNotify>); | ||
| } | ||
|
|
||
| fn register_is_done(&self) { |
There was a problem hiding this comment.
IMO, complete_register or finish_register would be better.
foriequal0
force-pushed
the
feature/cleanups
branch
from
54bd0fb to
06b3f97
Compare
remagpie
previously approved these changes
Dec 10, 2019
sgkim126
previously approved these changes
Dec 11, 2019
|
clippy is failing. |
foriequal0
force-pushed
the
feature/cleanups
branch
from
a992541 to
a86380e
Compare
`on_open_block` is called when the block is created, before processing any transactions included in the block.
This is a work-around to the currently order-dependant and non-deterministic initialization of Tendermint ConsensusEngine/Worker.
foriequal0
force-pushed
the
feature/cleanups
branch
from
a86380e to
2510cc0
Compare
|
Let me close this issue. We decided to implement snapshot sync on foundry first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cherry-picked some clean-ups, preparations in the snapshot sync PR: #1911