Adjust snapshot timing #1912
Merged
Adjust snapshot timing #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
force-pushed
the
feature/td-era-snapshot
branch
from
87fbf80 to
e1688e2
Compare
remagpie
reviewed
Dec 4, 2019
foriequal0
force-pushed
the
feature/td-era-snapshot
branch
from
e1688e2 to
f13fd95
Compare
This was referenced Dec 4, 2019
Closed
Also make tendermint::Worker::send_snapshot_notify use only block number
foriequal0
force-pushed
the
feature/td-era-snapshot
branch
from
f13fd95 to
c4500dd
Compare
remagpie
approved these changes
Dec 5, 2019
sgkim126
reviewed
Dec 5, 2019
The previous implementation required the current header, the parent header, and the grandparent header. @remagpie pointed out that the block number would be sufficient to implement it, without reading previous headers. |
sgkim126
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: Depends on: #1914
As described in the issue here(#1884), Snapshot should be taken at the next block of the term closing block.