Download the full snapshot target block #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
requested changes
Nov 25, 2019
foriequal0
requested changes
Nov 25, 2019
| } | ||
|
|
||
| pub fn import_bootstrap_block<'a>(&'a self, block: &'a Block, client: &Client, _importer_lock: &MutexGuard<()>) { | ||
| pub fn import_trusted_header<'a>(&'a self, header: &'a Header, client: &Client, _importer_lock: &MutexGuard<()>) { |
Contributor
There was a problem hiding this comment.
Why it takes unused _importer_lock?
Contributor
Author
There was a problem hiding this comment.
I don't know why. I just used the same interface as import_headers.
foriequal0
approved these changes
Nov 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original snapshot sync implementation downloaded only the header of the snapshot target.
It introduced lots of problems, so I and @foriequal0 decided to download the body of the snapshot target too.
SnapshotBodystate is added to theStateenum in sync extension.Also,
import_bootstrap_headerinClientis changed toimport_trusted_header,import_trusted_blockandforce_update_best_block.