Tendermint periodic snapshot #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a work-around to the currently order-dependant and non-deterministic initialization of Tendermint ConsensusEngine/Worker.
remagpie
reviewed
Nov 19, 2019
Comment on lines
+366
to
+368
| let client = client.client(); | ||
| let (tx, rx) = snapshot_notify::create(); | ||
| client.engine().register_snapshot_notify_sender(tx); |
There was a problem hiding this comment.
It has a little bit of a complicated story. In Tendermint, Worker waits for some register_* functions to be called before it fires up its event loop. It is implemented with crossbeam::channel and it requires to be called orderly and thoroughly. So I moved it there so the last register_ function is called unconditionally.
There was a problem hiding this comment.
These weird initialization steps need to be cleaned up, but it should be an another PR.
remagpie
approved these changes
Nov 19, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.