Import only desired bootstrap headers #1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
requested changes
Nov 15, 2019
remagpie
force-pushed
the
filter-bootstrap-header
branch
from
6ce2570 to
0a85a37
Compare
foriequal0
requested changes
Nov 15, 2019
sync/src/block/extension.rs
Outdated
| } | ||
| } | ||
| } | ||
| _ => cdebug!(SYNC, "Peer {} didn't have the snapshot header {}", from, hash), |
Contributor
There was a problem hiding this comment.
The log message is misleading. The inversion of [header] if header.hash() == hash is "headers is not [header]" (such as [], [h1, ...]), or header.hash() != hash. You should change it to "Peer {} responded with the invalid response. requested hash: {}, response length: {}"
Contributor
Author
There was a problem hiding this comment.
I thought it is checked in is_valid_response, but it seems it's not.
I'll fix this.
remagpie
force-pushed
the
filter-bootstrap-header
branch
from
0a85a37 to
b4553eb
Compare
foriequal0
approved these changes
Nov 15, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.