Enable TimerLoop to be dropped #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
force-pushed
the
feature/drop-timer-loop
branch
2 times, most recently
from
e1a2a5c to
dc0d761
Compare
sgkim126
reviewed
Jan 15, 2019
sgkim126
reviewed
Jan 15, 2019
foriequal0
force-pushed
the
feature/drop-timer-loop
branch
from
dc0d761 to
38a9734
Compare
foriequal0
force-pushed
the
feature/drop-timer-loop
branch
from
38a9734 to
43b6f36
Compare
Contributor
|
@foriequal0 Please, resolve the conflicts. |
sgkim126
requested changes
Apr 29, 2019
|
|
||
| fn clear_and_stop(&mut self) { | ||
| self.finished = true; | ||
| self.states.clear(); |
Contributor
There was a problem hiding this comment.
Would you explain why do we need to clear the states?
Contributor
Author
There was a problem hiding this comment.
self.states is for indexing items in self.heap. It is natural to drain/clear them in pair.
Contributor
Clone can accidentially lead to someone sharing strong ref to scheduler
foriequal0
force-pushed
the
feature/drop-timer-loop
branch
3 times, most recently
from
1500917 to
7e0b066
Compare
foriequal0
force-pushed
the
feature/drop-timer-loop
branch
from
7e0b066 to
99f22ae
Compare
sgkim126
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.