-
Notifications
You must be signed in to change notification settings - Fork 15
feat(criterion): make Bencher
implement Send + Sync
#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(criterion): make Bencher
implement Send + Sync
#116
Conversation
CodSpeed Instrumentation Performance ReportMerging #116 will degrade performances by 15.89%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #116 will degrade performances by 20.4%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Minor style nitpick: You could remove the let codspeed = &mut *self.codspeed;
variables altogether and use it directly when calling the functions (e.g. self.codspeed.start_benchmark
)
ad60ffa
to
1f8a754
Compare
Any chance this can get merged and released soon? Thanks! :D @art049 @not-matthias |
`criterion`'s `Bencher` implements `Send + Sync`, which allows running the benchmark itself on another thread. This allows something like `|b| /* my rayon thread pool */.install(|| b.iter(|| /* bench */))`.
1f8a754
to
97babdc
Compare
criterion
'sBencher
implementsSend + Sync
, which allows running the benchmark itself on another thread. This allows something like|b| /* my rayon thread pool */.install(|| b.iter(|| /* bench */))
.