Skip to content

Conversation

art049
Copy link
Member

@art049 art049 commented Jul 10, 2025

No description provided.

Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed Instrumentation Performance Report

Merging #110 will improve performances by 13.82%

Comparing cod-1134-running-cargo-bench-should-work-with-the-compat-layers (8dffbaf) with main (f6753d3)

Summary

⚡ 9 improvements
✅ 158 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
instant 363.6 ns 334.4 ns +8.72%
system_time 363.6 ns 334.4 ns +8.72%
sleep_100ns 566.1 ns 536.9 ns +5.43%
sleep_100us 566.1 ns 536.9 ns +5.43%
sleep_1ms 566.1 ns 536.9 ns +5.43%
sleep_1ns 566.1 ns 536.9 ns +5.43%
sleep_1us 566.1 ns 536.9 ns +5.43%

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me

@GuillaumeLagrange
Copy link
Contributor

@art049 not your PR, but we may want to update tolerance/update benches that are flaky in this repo, we always have noise due to the nature of the very simple tests that I'm afraid will hide real issues some day

Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed WallTime Performance Report

Merging #110 will degrade performances by 16.46%

Comparing cod-1134-running-cargo-bench-should-work-with-the-compat-layers (8dffbaf) with main (f6753d3)

Summary

⚡ 11 improvements
❌ 9 regressions
✅ 134 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
large_drop 173.9 µs 208.2 µs -16.46%
large_setup 13 ns 14 ns -7.14%
from_elem[4096] 322 ns 335 ns -3.88%
from_elem[8192] 478 ns 493 ns -3.04%
bench_array1[10] 9 ns 10 ns -10%
bench_array2[10] 9 ns 10 ns -10%
recursive_memoized[BTreeMap<u64, u64>, 10] 552 ns 570 ns -3.16%
generate_combinations[9] 4.2 µs 4.3 µs -3.62%
graph_coloring[5] 1,016 ns 968 ns +4.96%
n_queens_solver[4] 1.5 µs 1.6 µs -3.08%
n_queens_solver[6] 20.8 µs 20 µs +4.21%
permutations[5] 11.8 µs 11.1 µs +6.05%
count_set_bits[0] 8 ns 7 ns +14.29%
count_set_bits[1024] 8 ns 7 ns +14.29%
count_set_bits[255] 8 ns 7 ns +14.29%
count_set_bits[42] 8 ns 7 ns +14.29%
count_set_bits[65535] 8 ns 7 ns +14.29%
sleep_100ns 31.9 µs 25 µs +27.59%
sleep_100us 128.9 µs 118.4 µs +8.85%
sleep_1us 34.9 µs 17 µs ×2.1

@art049 art049 merged commit 8dffbaf into main Jul 10, 2025
14 checks passed
@art049 art049 deleted the cod-1134-running-cargo-bench-should-work-with-the-compat-layers branch July 10, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants